Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added transform info to Tracer Log #43528

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Added transform info to Tracer Log #43528

merged 2 commits into from
Dec 12, 2023

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Modified ModuleCallingContext so transform calls start with id 1. Trace log now contains callID for module and requesting module Fixed a phase numbering error from previous changes

PR validation:

Code compiles. Tested using a modified form of the framework transform test.

@Dr15Jones
Added transform info to Tracer Log
071049e 
Modified ModuleCallingContext so transform calls start with id 1.
Trace log now contains callID for module and requesting module
Fixed a phase numbering error from previous changes
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Dec 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43528/38110

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • FWCore/Framework (core)
  • FWCore/Services (core)

@cmsbuild, @smuzaffar, @makortel, @Dr15Jones can you please review it and eventually sign? Thanks.
@fwyzard, @missirol, @wddgit, @makortel this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43528/38111

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2023

Pull request #43528 was updated. @Dr15Jones, @smuzaffar, @makortel can you please check and sign again.

@makortel makortel mentioned this pull request Dec 8, 2023
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf78e/36388/summary.html
COMMIT: caf0c49
CMSSW: CMSSW_14_0_X_2023-12-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43528/36388/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf78e/36388/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf78e/36388/git-merge-result

Comparison Summary

Summary:

  • You potentially added 215 lines to the logs
  • Reco comparison results: 29525 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3430794
  • DQMHistoTests: Total failures: 88876
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3341895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.132 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.122 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.010 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@makortel
Copy link
Contributor

@cmsbuild, please test

Let's try to have cleaner comparisons.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aaf78e/36412/summary.html
COMMIT: caf0c49
CMSSW: CMSSW_14_0_X_2023-12-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43528/36412/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

Usual set of

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce3e9ba into cms-sw:master Dec 12, 2023
11 checks passed
This was referenced Dec 12, 2023
Merged
Merged
@Dr15Jones Dr15Jones deleted the transformTracerLog branch December 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @makortel @rappoccio